[CORE] Log error when -Xms equals -Xmx makes JVM heap shrinking ineffective#12480
Open
xumanbu wants to merge 1 commit into
Open
[CORE] Log error when -Xms equals -Xmx makes JVM heap shrinking ineffective#12480xumanbu wants to merge 1 commit into
xumanbu wants to merge 1 commit into
Conversation
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add a check in
DynamicOffHeapSizingMemoryTargetstatic initializer to detect when -Xms equals or is very close to -Xmx. In this scenario, the JVM heap size is fixed and System.gc() cannot shrink totalMemory (return committed pages to OS), making the shrinkOnHeapMemory mechanism ineffective. An error log is emitted to alert users, consistent with the existing checks for-XX:+ExplicitGCInvokesConcurrentand-XX:+DisableExplicitGC.fix:#12479
How was this patch tested?
Existing unit tests.